xianjingfeng commented on code in PR #74: URL: https://github.com/apache/incubator-uniffle/pull/74#discussion_r930567865
########## client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java: ########## @@ -38,6 +38,7 @@ import org.apache.uniffle.client.api.ShuffleReadClient; import org.apache.uniffle.client.response.CompressedShuffleBlock; import org.apache.uniffle.common.RssShuffleUtils; +import sun.nio.ch.DirectBuffer; Review Comment: I think there is no need to use `DirectBuffer` here, use `HeapByteBuffer` when decompress is better, in our internal version, we can use `HeapByteBuffer` or `DirectBuffer`, and we found no apparent difference in performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
