jerqi commented on code in PR #249:
URL: https://github.com/apache/incubator-uniffle/pull/249#discussion_r990615381
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileDeleteHandler.java:
##########
@@ -33,7 +32,7 @@ public class LocalFileDeleteHandler implements
ShuffleDeleteHandler {
@Override
public void delete(String[] storageBasePaths, String appId, String user) {
for (String basePath : storageBasePaths) {
- String shufflePath =
ShuffleStorageUtils.getFullShuffleDataFolder(basePath, appId);
+ final String shufflePath = basePath;
Review Comment:
Should we modify the name of `storageBasePaths`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
