zuston commented on PR #249: URL: https://github.com/apache/incubator-uniffle/pull/249#issuecomment-1272278548
> One question? Why do we add the concept of PurgeEvent? What's the advantage? Could we just add a shuffle level deletion method for StorageManager? Two reasons. 1. Make clearResourceThread clean two kinds of events of stage and app level data 2. I dont want to introduce extra delete method in StorageManager because most of deletion logic is the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
