zuston commented on code in PR #249:
URL: https://github.com/apache/incubator-uniffle/pull/249#discussion_r990755901
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/HdfsShuffleDeleteHandler.java:
##########
@@ -39,33 +38,35 @@ public HdfsShuffleDeleteHandler(Configuration hadoopConf) {
@Override
public void delete(String[] storageBasePaths, String appId, String user) {
- Path path = new
Path(ShuffleStorageUtils.getFullShuffleDataFolder(storageBasePaths[0], appId));
- boolean isSuccess = false;
- int times = 0;
- int retryMax = 5;
- long start = System.currentTimeMillis();
- LOG.info("Try delete shuffle data in HDFS for appId[{}] of user[{}] with
{}",appId, user, path);
- while (!isSuccess && times < retryMax) {
- try {
- FileSystem fileSystem = HadoopFilesystemProvider.getFilesystem(user,
path, hadoopConf);
- fileSystem.delete(path, true);
- isSuccess = true;
- } catch (Exception e) {
- times++;
- LOG.warn("Can't delete shuffle data for appId[" + appId + "] with " +
times + " times", e);
+ for (String deletePath : storageBasePaths) {
+ final Path path = new Path(deletePath);
+ boolean isSuccess = false;
+ int times = 0;
+ int retryMax = 5;
Review Comment:
This is the original value. I dont know the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
