frankliee commented on code in PR #254:
URL: https://github.com/apache/incubator-uniffle/pull/254#discussion_r991006602
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -278,4 +281,17 @@ public Double apply(String in) {
public static TypedConfigBuilder<String> createStringBuilder(ConfigBuilder
builder) {
return builder.stringConf();
}
+
+ public static RssConf toRssConf(SparkConf sparkConf) {
Review Comment:
Why change conf design in this ZSTD PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]