zuston commented on code in PR #254:
URL: https://github.com/apache/incubator-uniffle/pull/254#discussion_r991010587
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -278,4 +281,17 @@ public Double apply(String in) {
public static TypedConfigBuilder<String> createStringBuilder(ConfigBuilder
builder) {
return builder.stringConf();
}
+
+ public static RssConf toRssConf(SparkConf sparkConf) {
Review Comment:
I want to make compressorFactory accessed by MR and Spark to create concrete
codec which will be initialized by specified conf, so it will have two choice.
1. Use the shareable RssConf like this PR
2. Introduce the extra config bean of compression (I think there is no need
to do so)
Besides, I want to refactor the code of MR/Spark client conf entry, this PR
is to do some partial work. Please refer to #200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
