jerqi commented on PR #276: URL: https://github.com/apache/incubator-uniffle/pull/276#issuecomment-1292875866
> > So I feel that `maxRounds` isn't reasonable for this situation. > > I have another solution： > > 1. Set maxFailTimes and failTime in every handler > 2. When `readShuffleData` fail, ++failTime > 3. When `readShuffleData` success, failTime = 0 > 4. If failTime >= maxFailTimes , finished=true > What do you think? MaxFailureTime will tolerate the logic of replicas, this is my biggest concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
