xianjingfeng commented on code in PR #276:
URL: https://github.com/apache/incubator-uniffle/pull/276#discussion_r1005168462
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/HdfsClientReadHandler.java:
##########
@@ -127,21 +127,32 @@ public ShuffleDataResult readShuffleData() {
init(fullShufflePath);
}
- if (readHandlerIndex >= readHandlers.size()) {
+ if (finished()) {
return new ShuffleDataResult();
}
- HdfsShuffleReadHandler hdfsShuffleFileReader =
readHandlers.get(readHandlerIndex);
- ShuffleDataResult shuffleDataResult =
hdfsShuffleFileReader.readShuffleData();
-
- while (shuffleDataResult == null) {
- ++readHandlerIndex;
+ HdfsShuffleReadHandler hdfsShuffleFileReader;
Review Comment:
I think no nessential, for unify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
