kaijchen commented on code in PR #281:
URL: https://github.com/apache/incubator-uniffle/pull/281#discussion_r1012467765
##########
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java:
##########
@@ -143,7 +143,7 @@ public Storage selectStorage(ShuffleDataFlushEvent event) {
event.getStartPartition()));
if (storage.containsWriteHandler(event.getAppId(), event.getShuffleId(),
event.getStartPartition())
&& storage.isCorrupted()) {
- throw new RuntimeException("storage " + storage.getBasePath() + " is
corrupted");
Review Comment:
The removal of the Exception seems irreverent with the title, can you revert
this change?
In another word, you should change it in another PR if it's really needed.
##########
storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java:
##########
@@ -73,8 +73,12 @@ public ServerReadHandler
getOrCreateReadHandler(CreateShuffleReadHandlerRequest
protected abstract ServerReadHandler
newReadHandler(CreateShuffleReadHandlerRequest request);
public boolean containsWriteHandler(String appId, int shuffleId, int
partition) {
Review Comment:
This fix looks good, can you add a UT to cover this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
