kaijchen commented on code in PR #281:
URL: https://github.com/apache/incubator-uniffle/pull/281#discussion_r1012652785
##########
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java:
##########
@@ -143,7 +143,7 @@ public Storage selectStorage(ShuffleDataFlushEvent event) {
event.getStartPartition()));
if (storage.containsWriteHandler(event.getAppId(), event.getShuffleId(),
event.getStartPartition())
&& storage.isCorrupted()) {
- throw new RuntimeException("storage " + storage.getBasePath() + " is
corrupted");
Review Comment:
> This exception will help application fast fail. If a storage which ever
was written with the application data, although we write new data to another
storage, they will also fail. So we throw an exception here,.
Is it better to throw a different kind of Exception here such as
`IllegalStateException` and catch it in the test (where the Exception is
expected).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
