zuston commented on PR #294: URL: https://github.com/apache/incubator-uniffle/pull/294#issuecomment-1301999420
Thanks for proposing this PR, overall it will benefit more for some big memory shuffle-server. After a brief look, I have a question that whether the memory size of `processBlockId` and `expectBlockId` are very large, maybe it will have some extra overhead especially for frequently `getInMemoryData`. Can we send one time for a same `MemoryClientReadHandler` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
