frankliee commented on code in PR #294:
URL: https://github.com/apache/incubator-uniffle/pull/294#discussion_r1013552643
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBuffer.java:
##########
@@ -121,13 +122,14 @@ public Map<Long, List<ShufflePartitionedBlock>>
getInFlushBlockMap() {
// 1. generate buffer segments and other info: if blockId exist, start with
which eventId
// 2. according to info from step 1, generate data
// todo: if block was flushed, it's possible to get duplicated data
- public synchronized ShuffleDataResult getShuffleData(
- long lastBlockId, int readBufferSize) {
+ public ShuffleDataResult getShuffleData(
Review Comment:
Why remove `synchronized ` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
