xianjingfeng commented on code in PR #281:
URL: https://github.com/apache/incubator-uniffle/pull/281#discussion_r1012865591
##########
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java:
##########
@@ -143,7 +143,7 @@ public Storage selectStorage(ShuffleDataFlushEvent event) {
event.getStartPartition()));
if (storage.containsWriteHandler(event.getAppId(), event.getShuffleId(),
event.getStartPartition())
&& storage.isCorrupted()) {
- throw new RuntimeException("storage " + storage.getBasePath() + " is
corrupted");
Review Comment:
> `DiskErrorToleranceTest#diskErrorTest` will fail without this change.
https://github.com/apache/incubator-uniffle/actions/runs/3328036207/jobs/5503556615
But how do I deal with this problem. I think this ut is reasonable. Merge
another pr first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
