jerqi commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1020464859
##########
proto/src/main/proto/Rss.proto:
##########
@@ -302,6 +302,7 @@ service CoordinatorServer {
message AppHeartBeatRequest {
string appId = 1;
+ string user = 2;
Review Comment:
Why do the heartbeat need the `user`?
##########
proto/src/main/proto/Rss.proto:
##########
@@ -302,6 +302,7 @@ service CoordinatorServer {
message AppHeartBeatRequest {
string appId = 1;
+ string user = 2;
Review Comment:
When we register the shuffle, we put the user information to the shuffle
server. Is it enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
