jerqi commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1020743750
##########
proto/src/main/proto/Rss.proto:
##########
@@ -302,6 +302,7 @@ service CoordinatorServer {
message AppHeartBeatRequest {
string appId = 1;
+ string user = 2;
Review Comment:
I can't get your point. I feel it's unnecessary and strange that we put the
user information to the heartbeat. We have register the user information to
shuffle server. Why do we need heartbeat? We hope we can reduce the repeated
information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
