jerqi commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1025922043
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -196,13 +196,14 @@ public void reportClientOperation(
}
@Override
- public void appHeartbeat(
- AppHeartBeatRequest request,
- StreamObserver<AppHeartBeatResponse> responseObserver) {
+ public void registerApplicationInfo(
Review Comment:
Why do we rename `appHeartbeat` to `registerApplicationInfo`? I mean that we
can add a method `registerApplicationInfo`.
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ApplicationManager.java:
##########
@@ -282,6 +328,58 @@ private String getStorageHost(String remoteStoragePath) {
return storageHost;
}
+ public void detectUserResource() {
Review Comment:
Should the application manager involve the quota logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
