smallzhongfeng commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1025975711
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -196,13 +196,14 @@ public void reportClientOperation(
}
@Override
- public void appHeartbeat(
- AppHeartBeatRequest request,
- StreamObserver<AppHeartBeatResponse> responseObserver) {
+ public void registerApplicationInfo(
Review Comment:
> Maybe we could add a rpc method called registerApplicationInfo for
Coordinator.
Didn't it say to add a new rpc method? If not, the server still needs to
send the user's attribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
