smallzhongfeng commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1027322213
##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -239,6 +239,7 @@ public Thread newThread(Runnable r) {
long heartbeatInterval = conf.getLong(RssMRConfig.RSS_HEARTBEAT_INTERVAL,
RssMRConfig.RSS_HEARTBEAT_INTERVAL_DEFAULT_VALUE);
long heartbeatTimeout = conf.getLong(RssMRConfig.RSS_HEARTBEAT_TIMEOUT,
heartbeatInterval / 2);
+ client.registerApplicationInfo(appId, heartbeatTimeout, "user");
Review Comment:
We need this because `applicationManager` remove expired app need `user`.
When our Spark does not use the AppQuota checker, it also needs register
application info, so it will not have much impact here.
##########
client-spark/spark3/pom.xml:
##########
@@ -39,6 +39,13 @@
<artifactId>spark-core_${scala.binary.version}</artifactId>
<version>${spark.version}</version>
<scope>provided</scope>
+ <exclusions>
Review Comment:
I forgot to remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
