jerqi commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1027446764
##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -239,6 +239,7 @@ public Thread newThread(Runnable r) {
long heartbeatInterval = conf.getLong(RssMRConfig.RSS_HEARTBEAT_INTERVAL,
RssMRConfig.RSS_HEARTBEAT_INTERVAL_DEFAULT_VALUE);
long heartbeatTimeout = conf.getLong(RssMRConfig.RSS_HEARTBEAT_TIMEOUT,
heartbeatInterval / 2);
+ client.registerApplicationInfo(appId, heartbeatTimeout, "user");
Review Comment:
It seems that this isn't compatible feature. If we use old client to connect
new service, something wrong will happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
