xianjingfeng commented on code in PR #359:
URL: https://github.com/apache/incubator-uniffle/pull/359#discussion_r1032726927
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ApplicationManager.java:
##########
@@ -75,10 +77,13 @@ public ApplicationManager(CoordinatorConf conf) {
throw new UnsupportedOperationException("Unsupported selected storage
strategy.");
}
expired = conf.getLong(CoordinatorConf.COORDINATOR_APP_EXPIRED);
- QuotaManager quotaManager = new QuotaManager(conf);
- this.currentUserAndApp = quotaManager.getCurrentUserAndApp();
- this.appIdToUser = quotaManager.getAppIdToUser();
- this.defaultUserApps = quotaManager.getDefaultUserApps();
+ if
(conf.get(CoordinatorConf.COORDINATOR_ACCESS_CHECKERS).stream().map(String::trim).collect(Collectors.toList())
Review Comment:
```java
String quotaCheckerClass = AccessQuotaChecker.class.getCanonicalName();
for (String checker : conf.get(COORDINATOR_ACCESS_CHECKERS)) {
if (quotaCheckerClass.equals(checker.trim())) {
this.quotaManager = new QuotaManager(conf);
this.currentUserAndApp = quotaManager.getCurrentUserAndApp();
this.appIdToUser = quotaManager.getAppIdToUser();
this.defaultUserApps = quotaManager.getDefaultUserApps();
break;
}
}
```
Do you think it's good to write like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
