smallzhongfeng commented on code in PR #359:
URL: https://github.com/apache/incubator-uniffle/pull/359#discussion_r1032733181
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/QuotaManager.java:
##########
@@ -53,13 +53,14 @@ public class QuotaManager {
private final Map<String, Integer> defaultUserApps = Maps.newConcurrentMap();
public QuotaManager(CoordinatorConf conf) {
- this.quotaFilePath =
conf.get(CoordinatorConf.COORDINATOR_QUOTA_DEFAULT_PATH);;
+ this.quotaFilePath =
conf.get(CoordinatorConf.COORDINATOR_QUOTA_DEFAULT_PATH);
final Long updateTime =
conf.get(CoordinatorConf.COORDINATOR_QUOTA_UPDATE_INTERVAL);
try {
hadoopFileSystem = HadoopFilesystemProvider.getFilesystem(new
Path(quotaFilePath), new Configuration());
} catch (Exception e) {
LOG.error("Cannot init remoteFS on path : " + quotaFilePath, e);
}
+ LOG.warn("We will update the quota of users regularly.");
Review Comment:
This is to prompt the user that QuotaManager starts normally.
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/QuotaManager.java:
##########
@@ -53,13 +53,14 @@ public class QuotaManager {
private final Map<String, Integer> defaultUserApps = Maps.newConcurrentMap();
public QuotaManager(CoordinatorConf conf) {
- this.quotaFilePath =
conf.get(CoordinatorConf.COORDINATOR_QUOTA_DEFAULT_PATH);;
+ this.quotaFilePath =
conf.get(CoordinatorConf.COORDINATOR_QUOTA_DEFAULT_PATH);
Review Comment:
If the quotaFilePath is empty, the quota for each user is the default value
of rss.coordinator.quota.default.app.num. No exception is thrown, but logs can
be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
