jerqi commented on code in PR #358:
URL: https://github.com/apache/incubator-uniffle/pull/358#discussion_r1033394876
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -151,6 +152,19 @@ protected Entry<Range<Integer>, ShuffleBuffer>
getShuffleBufferEntry(
public ShuffleDataResult getShuffleData(
String appId, int shuffleId, int partitionId, long blockId,
int readBufferSize) {
+ return getShuffleData(
+ appId,
+ shuffleId,
+ partitionId,
+ blockId,
+ readBufferSize,
+ null
Review Comment:
Could we pass an empty collection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
