jerqi commented on code in PR #358:
URL: https://github.com/apache/incubator-uniffle/pull/358#discussion_r1033799653
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/reader/RssShuffleReader.java:
##########
@@ -119,6 +120,9 @@ public RssShuffleReader(
this.partitionToShuffleServers = rssShuffleHandle.getPartitionToServers();
this.rssConf = rssConf;
this.dataDistributionType = dataDistributionType;
+ // This mechanism of expectedTaskIdsBitmap filter is to filter out the
most of data.
+ // especially for AQE skew optimization
+ this.expectedTaskIdsBitmapFilterEnable = mapEndIndex == Integer.MAX_VALUE
? false : true;
Review Comment:
If this is the last reduce partition, may the range of mapId be [n,
Integer.MAX_VALUE]?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
