tiantingting5435 commented on code in PR #360:
URL: https://github.com/apache/incubator-uniffle/pull/360#discussion_r1033594619
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -188,7 +188,7 @@ public RssShuffleManager(SparkConf sparkConf, boolean
isDriver) {
// External shuffle service is not supported when using remote shuffle
service
sparkConf.set("spark.shuffle.service.enabled", "false");
LOG.info("Disable external shuffle service in RssShuffleManager.");
- if (!sparkConf.getBoolean(RssSparkConfig.RSS_TEST_FLAG.key(), false)) {
+ if (!sparkConf.getBoolean(RssSparkConfig.RSS_TEST_MODE.key(), false)) {
Review Comment:
The change here is to unify the test flags and use rss.test.mode.enable to
confirm if it is a test mode. Using multiple parameters to mark a test mode
tends to create redundancy and confusion in the parameters, UT fails I can fix
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
