jerqi commented on code in PR #360:
URL: https://github.com/apache/incubator-uniffle/pull/360#discussion_r1033602706
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -188,7 +188,7 @@ public RssShuffleManager(SparkConf sparkConf, boolean
isDriver) {
// External shuffle service is not supported when using remote shuffle
service
sparkConf.set("spark.shuffle.service.enabled", "false");
LOG.info("Disable external shuffle service in RssShuffleManager.");
- if (!sparkConf.getBoolean(RssSparkConfig.RSS_TEST_FLAG.key(), false)) {
+ if (!sparkConf.getBoolean(RssSparkConfig.RSS_TEST_MODE.key(), false)) {
Review Comment:
It's a little difficult to unify them. Because RSS_TEST_FLAG is used for
ShuffleFlushManagerTest, RSS_TEST_MODE is used for integration tests and uts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
