jerqi commented on code in PR #383:
URL: https://github.com/apache/incubator-uniffle/pull/383#discussion_r1037819492
##########
server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java:
##########
@@ -36,6 +38,9 @@ public class ShuffleDataFlushEvent {
private final Supplier<Boolean> valid;
private final ShuffleBuffer shuffleBuffer;
private final AtomicInteger retryTimes = new AtomicInteger();
+ private boolean isPended = false;
+ private StorageManager underStorageManager;
Review Comment:
> Emm.. But I just want to bound the concrete `storageManager` into event
here for writing in `MultiStorageManager`.
Relation is not good idea. But it's better than putting StorageManager into
event. If StorageManager is ok, should we put ShuffleFlushManager into the
ShuffleFlushEvent instead of `Supplier<Boolean> valid`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
