zuston commented on PR #383:
URL:
https://github.com/apache/incubator-uniffle/pull/383#issuecomment-1335012605
> To implement what you want We just modify here
>
> ```
> private StorageManager selectStorageManager(ShuffleDataFlushEvent event)
{
> StorageManager storageManager =
storageManagerCache.getIfPresent(event);
> if (storageManager != null) {
> // modify here if storageManager is not canWrite we fallback.
> return storageManager;
> }
> if (event.getSize() > flushColdStorageThresholdSize) {
> storageManager = coldStorageManager;
> } else {
> storageManager = warmStorageManager;
> }
>
> if (!storageManager.canWrite(event)) {
> storageManager = storageManagerFallbackStrategy.tryFallback(
> storageManager, event, warmStorageManager, coldStorageManager);
> }
> storageManagerCache.put(event, storageManager);
> return storageManager;
> }
> ```
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
