jerqi commented on PR #386: URL: https://github.com/apache/incubator-uniffle/pull/386#issuecomment-1336843709
> 1. Should we put `checker` and `access` folders together? Because they are related. > 2. Another concern is the package renaming, which will make this PR incompatible with original config, like ‘org.apache.uniffle.coordinator.checker.AccessClusterLoadChecker’. Further more, I suggest that we'd better not to use the package name as the config of strategy in the future @jerqi Do you think so? 1. move checker directory to access directory? 2. Em..it's ok for me actually. We can add a document to explain how migrate to higher version if we make some imcompatible changes. Or we add short name for some configs. Or we introduce the deprecated configuration option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
