zuston commented on PR #386: URL: https://github.com/apache/incubator-uniffle/pull/386#issuecomment-1336917427
> > +1. Short name or concrete strategy name will be better. > > If we use short name, this pr will also be incompatible change. Yes. The refactor process will always make incompatible change. I think it could be optimized in later PRs, currently the strategies are bound to package name, it looks unreasonable. We should reach a consensus that this way is no longer supported for new PRs. Do you think so? By the way, I just think more when reviewing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
