xianjingfeng commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1049514602
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -256,6 +251,9 @@ public void sendShuffleData(SendShuffleDataRequest req,
break;
}
}
+ // since the required buffer id is only used once, the shuffle client
would try to require another buffer.
+ // we should remove this require buffer whether the cache shuffle data
succeeded or not
+ manager.removeRequireBufferId(requireBufferId);
Review Comment:
If all goes well, preAllocated memory will be released when cache block.
but `usedMemory` will be released after flush finish. And
`preAllocatedBufferCheck` will release `usedMemory`
So, if preAllocatedBufferCheck clean the require buffer when caching blocks,
`usedMemory` will be released twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
