advancedxy commented on code in PR #424:
URL: https://github.com/apache/incubator-uniffle/pull/424#discussion_r1050488135


##########
integration-test/common/src/test/java/org/apache/uniffle/test/DiskErrorToleranceTest.java:
##########
@@ -87,8 +86,7 @@ public void createClient() {
   public void closeClient() {
     shuffleServerClient.close();
   }
-
-  @Test
+  
   public void diskErrorTest() throws Exception {

Review Comment:
   > @advancedxy Due to this change, it will make diskErrorTest fail. So I 
remove it temporarily
   
   For this case, I believe a @Disabled annotation with a reason would be 
better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to