zuston commented on code in PR #424:
URL: https://github.com/apache/incubator-uniffle/pull/424#discussion_r1050680802
##########
server/src/main/java/org/apache/uniffle/server/ShuffleDataReadEvent.java:
##########
@@ -17,16 +17,20 @@
package org.apache.uniffle.server;
+import org.apache.uniffle.common.PartitionRange;
+
public class ShuffleDataReadEvent {
private String appId;
private int shuffleId;
- private int startPartition;
+ private int partitionId;
+ private PartitionRange partitionRange;
- public ShuffleDataReadEvent(String appId, int shuffleId, int startPartition)
{
+ public ShuffleDataReadEvent(String appId, int shuffleId, int partitionId,
int[] range) {
Review Comment:
> Then an int of startPartition should be sufficient, just like how
ShuffleDataFlushEvent did.
Yes. I will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
