zuston commented on code in PR #435:
URL: https://github.com/apache/incubator-uniffle/pull/435#discussion_r1053961573


##########
proto/src/main/proto/Rss.proto:
##########
@@ -77,6 +77,7 @@ message GetLocalShuffleDataRequest {
   int64 offset = 6;
   int32 length = 7;
   int64 timestamp = 8;
+  int32 storageId = 9;

Review Comment:
   The original shuffle-data reading will follow the rule
   1. Reading the remote whole index file to split and filter to get the 
required segments
   2. Reading the shuffle-data according to above segment's offset and length 
one by one
   
   If we expose the unified abstraction for client to obey above reading 
sequence, it means we have to compose multiple files into abstract one and 
re-calculate the offset and length for every request to map the real file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to