zuston commented on code in PR #435:
URL: https://github.com/apache/incubator-uniffle/pull/435#discussion_r1054321840
##########
proto/src/main/proto/Rss.proto:
##########
@@ -77,6 +77,7 @@ message GetLocalShuffleDataRequest {
int64 offset = 6;
int32 length = 7;
int64 timestamp = 8;
+ int32 storageId = 9;
Review Comment:
> I don't think this is a good design choice. It's leaking too much details
to client.
Yes. I also prefer giving a unified abstraction to hide the multiple under
storages' detail for client, but currently I have no good ideas on this.
> And there're other storage types that doesn't need local storage, such as
memory and memory_hdfs.
Emmm... Only localfile storage will use this proto. Memory reading will use
an independent api and HDFS reading will fetch data directly from HDFS datanode
instead of fetch remote data from shuffle-server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
