jerqi commented on code in PR #424:
URL: https://github.com/apache/incubator-uniffle/pull/424#discussion_r1054040815
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -403,8 +427,11 @@ public ShuffleIndexResult getShuffleIndex(
request.setPartitionNum(partitionNum);
request.setStorageType(storageType);
request.setRssBaseConf(conf);
-
- Storage storage = storageManager.selectStorage(new
ShuffleDataReadEvent(appId, shuffleId, partitionId));
+ int[] range = ShuffleStorageUtils.getPartitionRange(partitionId,
partitionNumPerRange, partitionNum);
+ Storage storage = storageManager.selectStorage(new
ShuffleDataReadEvent(appId, shuffleId, partitionId, range[0]));
+ if (storage == null) {
+ throw new FileNotFoundException("No such data in current storage
manager.");
Review Comment:
Why do we throw a `FileNotFoundException`?
##########
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java:
##########
@@ -139,33 +143,53 @@ public class LocalStorageManager extends
SingleStorageManager {
@Override
public Storage selectStorage(ShuffleDataFlushEvent event) {
- LocalStorage storage =
localStorages.get(ShuffleStorageUtils.getStorageIndex(
- localStorages.size(),
- event.getAppId(),
- event.getShuffleId(),
- event.getStartPartition()));
- if (storage.containsWriteHandler(event.getAppId(), event.getShuffleId(),
event.getStartPartition())
- && storage.isCorrupted()) {
- LOG.error("storage " + storage.getBasePath() + " is corrupted");
- }
- if (storage.isCorrupted()) {
- storage = getRepairedStorage(event.getAppId(), event.getShuffleId(),
event.getStartPartition());
+ String appId = event.getAppId();
+ int shuffleId = event.getShuffleId();
+ int partitionId = event.getStartPartition();
+
+ LocalStorage storage = partitionsOfStorage.get(UnionKey.toKey(appId,
shuffleId, partitionId));
+ if (storage != null) {
+ if (storage.isCorrupted()) {
+ if (storage.containsWriteHandler(appId, shuffleId, partitionId)) {
+ throw new RuntimeException("LocalStorage: " + storage.getBasePath()
+ " is corrupted.");
Review Comment:
Do we ensure that we should add this exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
