zuston commented on code in PR #424:
URL: https://github.com/apache/incubator-uniffle/pull/424#discussion_r1054048881
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -403,8 +427,11 @@ public ShuffleIndexResult getShuffleIndex(
request.setPartitionNum(partitionNum);
request.setStorageType(storageType);
request.setRssBaseConf(conf);
-
- Storage storage = storageManager.selectStorage(new
ShuffleDataReadEvent(appId, shuffleId, partitionId));
+ int[] range = ShuffleStorageUtils.getPartitionRange(partitionId,
partitionNumPerRange, partitionNum);
+ Storage storage = storageManager.selectStorage(new
ShuffleDataReadEvent(appId, shuffleId, partitionId, range[0]));
+ if (storage == null) {
+ throw new FileNotFoundException("No such data in current storage
manager.");
Review Comment:
The exception of FileNotFoundException could be handled by
`getLocalShuffleIndex` grpc layer, because maybe there is no local storage when
directly flushing to HDFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
