advancedxy commented on PR #428: URL: https://github.com/apache/incubator-uniffle/pull/428#issuecomment-1362463441
> This solution will reduce the preAllocatedSize release speed. Especially when we use LOCAL_ORDER. So i think we should do a performance test. You mean the `preAllocatedSize` doesn't decreased per each `cacheShuffleData` call? For this new solution, I believe it's possible to do that and maintains correct `preAllocatedSize`. However I am not sure that would make a big difference here. Could you elaborate a bit more how `LOCAL_ORDER` would be influenced? As for performance test, do you have any example job for references? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
