xianjingfeng commented on PR #428: URL: https://github.com/apache/incubator-uniffle/pull/428#issuecomment-1362623406
> Yeah, that's possible.... But the flush trigger is not non-deterministic anyway, it's trigged by outside's requests, which may vary. I still don't get why this kind of change would affect `LOCAL_ORDER` optimization or bring performance penalty here. 1.If the memory release is slow, the client write speed will be affected. When I did #159 , i encountered similar problems. 2.`LOCAL_ORDER` will affect performance when cache data, but i am not sure how much impact. In general, there will be a lot of performance impact if this place is not handled well. So, i think simple test is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
