zuston commented on PR #428: URL: https://github.com/apache/incubator-uniffle/pull/428#issuecomment-1362729663
Sorry, I missed this thread. I need some time to surf the commits changelog timeline and currently, I could only give some of my thoughts. From my side, I think the mechanism of requiring allocation seems like token bucket algorithm, the most difference is the bucket size depending on the free-memory, which is a dynamic bucket. Based on this, we should use the global lock when releasing or getting, this is the key to solve the problem mentioned in description. > LOCAL_ORDER is an option and it won't give too much performance impact. Because the blocks that we sort won't be very many and we only compare the taskId that isn't a big key. +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
