zuston commented on PR #428: URL: https://github.com/apache/incubator-uniffle/pull/428#issuecomment-1363691361
After surfing the whole process of requiring/releasing pre-allocated size, I have a question that why the preAllocatedSize is added to two vars of `ShuffleBufferManager.usedMemory` and `ShuffleBufferManager.preAllocatedSize` in here (https://github.com/apache/incubator-uniffle/blob/53212923328194fafa5ae94aa216ab04f06fbd13/server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java#L242-L255). And I still can't find the key of this pr to solve the negative preAllocatedSize. Could you help describe more? @advancedxy > Lock isn't the only mechinsm to avoid OOM. Emm.. Yes. But in current codebase, the requiring pre-allocation operation is guarded by the global lock, which is shown in above code snippet. @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
