advancedxy commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1057217234
##########
common/src/main/java/org/apache/uniffle/common/ShufflePartitionedData.java:
##########
@@ -49,4 +49,15 @@ public ShufflePartitionedBlock[] getBlockList() {
return blockList;
}
+ public int getTotalBlockSize() {
Review Comment:
> Could we reuse this result?
Yeah I have considered reuse the result from ShuffleBuffer and
`cacheShuffleData` in ShufflerBufferManager.
But I cannot find an elegant way to pass the size result back to caller,
thus I moved the calculation logic to `ShufflePartitionedData`. Do you have any
other suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
