advancedxy commented on code in PR #447:
URL: https://github.com/apache/incubator-uniffle/pull/447#discussion_r1057084319
##########
storage/src/test/java/org/apache/uniffle/storage/util/ShuffleStorageUtilsTest.java:
##########
@@ -266,5 +266,9 @@ public void getPartitionRangeTest() {
range = ShuffleStorageUtils.getPartitionRange(2, 3, 5);
Review Comment:
Some other cases may be added, such as:
1. partitionNumberPerRange = 1, and the `getPartitionRange` for start and
end ranges.
2. partitionNumberPerRange = partitionNum
3. partitionNumberPerRange = 7, 11 etc, a primary number, and partitionId in
start, end ranges, or some partitionId randomly generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
