a-li commented on code in PR #447:
URL: https://github.com/apache/incubator-uniffle/pull/447#discussion_r1057426996
##########
storage/src/test/java/org/apache/uniffle/storage/util/ShuffleStorageUtilsTest.java:
##########
@@ -251,6 +251,9 @@ public void getPartitionRangeTest() {
int[] range = ShuffleStorageUtils.getPartitionRange(0, 1, 5);
assertEquals(0, range[0]);
assertEquals(0, range[1]);
+ range = ShuffleStorageUtils.getPartitionRange(5, 1, 5);
+ assertEquals(5, range[0]);
Review Comment:
@jerqi Saw your comment in the bottom thread. Just so that we are on the
same page here, for `partitionId` >= `partitionNum`, is it supposed to return
null then? Especially asking for the `partitionId` == `partitionNum` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
