advancedxy commented on code in PR #449: URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1064141395
########## storage/src/main/java/org/apache/uniffle/storage/common/DefaultStorageTypeProvider.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.storage.common; + +import org.apache.uniffle.common.storage.SingleStorageType; + +public class DefaultStorageTypeProvider implements StorageTypeProvider { + @Override + public SingleStorageType getStorageTypeFor(String baseDir) { + return SingleStorageType.HDD; Review Comment: Thanks for the information. I will verify this command's output when I got a linux env. However this is only valid for host/vm deployment, Uniffle Shuffle Server will be and should be deployed to container environments, and the data dir might be mounted by container runtime, the info provided by the linux kernel might not be accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
