advancedxy commented on code in PR #449:
URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1064141944
##########
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java:
##########
@@ -94,19 +101,26 @@ public class LocalStorageManager extends
SingleStorageManager {
// We must make sure the order of `storageBasePaths` and `localStorages`
is same, or some unit test may be fail
CountDownLatch countDownLatch = new
CountDownLatch(storageBasePaths.size());
AtomicInteger successCount = new AtomicInteger();
+ ServiceLoader<StorageTypeProvider> loader =
ServiceLoader.load(StorageTypeProvider.class);
Review Comment:
I think one is not enough, especially when you need to provide your own
provider logic.
Although, the current logic may not handle provider evaluation order
properly. But we can modify that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
