jerqi commented on code in PR #449:
URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1065635636
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ServerNode.java:
##########
@@ -44,6 +51,21 @@ public ServerNode(
int eventNumInFlush,
Set<String> tags,
boolean isHealthy) {
+ this(id, ip, port, usedMemory, preAllocatedMemory, availableMemory,
eventNumInFlush, tags, isHealthy,
+ Maps.newHashMap());
+ }
+
+ public ServerNode(
+ String id,
+ String ip,
+ int port,
+ long usedMemory,
+ long preAllocatedMemory,
+ long availableMemory,
+ int eventNumInFlush,
+ Set<String> tags,
+ boolean isHealthy,
+ Map<String, RssProtos.StorageInfo> storageInfoMap) {
Review Comment:
Could we use `StorageInfo` to replace `RssProtos.StorageInfo`? Is this style
consistent with other places?
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ServerNode.java:
##########
@@ -44,6 +51,21 @@ public ServerNode(
int eventNumInFlush,
Set<String> tags,
boolean isHealthy) {
+ this(id, ip, port, usedMemory, preAllocatedMemory, availableMemory,
eventNumInFlush, tags, isHealthy,
+ Maps.newHashMap());
+ }
+
+ public ServerNode(
+ String id,
+ String ip,
+ int port,
+ long usedMemory,
+ long preAllocatedMemory,
+ long availableMemory,
+ int eventNumInFlush,
+ Set<String> tags,
+ boolean isHealthy,
+ Map<String, RssProtos.StorageInfo> storageInfoMap) {
this.id = id;
Review Comment:
Is this feature a compatible feature? Can coordinator recognize the old
server's request?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -336,6 +336,12 @@ public class ShuffleServerConf extends RssBaseConf {
.withDescription("Threshold when flushing shuffle data to persistent
storage, recommend value would be 256K, "
+ "512K, or even 1M");
+ public static final ConfigOption<String> STORAGE_MEDIA_PROVIDER_ENV_KEY =
ConfigOptions
+ .key("rss.server.localStorageProvider.from.env.key")
Review Comment:
Could we modify the key name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
