jerqi commented on code in PR #449:
URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1065719091
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ServerNode.java:
##########
@@ -44,6 +51,21 @@ public ServerNode(
int eventNumInFlush,
Set<String> tags,
boolean isHealthy) {
+ this(id, ip, port, usedMemory, preAllocatedMemory, availableMemory,
eventNumInFlush, tags, isHealthy,
+ Maps.newHashMap());
+ }
+
+ public ServerNode(
+ String id,
+ String ip,
+ int port,
+ long usedMemory,
+ long preAllocatedMemory,
+ long availableMemory,
+ int eventNumInFlush,
+ Set<String> tags,
+ boolean isHealthy,
+ Map<String, RssProtos.StorageInfo> storageInfoMap) {
Review Comment:
Should we convert from `RssProtos.StorageInfo` to `StorageInfo` in the
`RssProtos.StorageInfo`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
