xianjingfeng commented on code in PR #470:
URL: https://github.com/apache/incubator-uniffle/pull/470#discussion_r1067667767
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -246,6 +259,18 @@ public SendShuffleDataResult sendShuffleData(String appId,
List<ShuffleBlockInfo
// which is minimum number when there is at most *replicaWrite - replica*
sending server failures.
for (ShuffleBlockInfo sbi : shuffleBlockInfoList) {
List<ShuffleServerInfo> allServers = sbi.getShuffleServerInfos();
+ if (replica > 1 && !shuffleServerBlacklist.isEmpty()) {
+ // allServers is shared and is not thread safe
+ synchronized (this) {
+ for (int i = allServers.size() - 2; i >= 0; i--) {
+ ShuffleServerInfo serverInfo = allServers.get(i);
+ if (shuffleServerBlacklist.contains(serverInfo)) {
Review Comment:
If all the servers are added the blacklist, the sending order will be third
-> second -> first, it all servers are unavailable, the task will be failed.
And if some servers become available, it will be removed from the blacklist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
