xianjingfeng commented on code in PR #470:
URL: https://github.com/apache/incubator-uniffle/pull/470#discussion_r1067756896
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -246,6 +259,18 @@ public SendShuffleDataResult sendShuffleData(String appId,
List<ShuffleBlockInfo
// which is minimum number when there is at most *replicaWrite - replica*
sending server failures.
for (ShuffleBlockInfo sbi : shuffleBlockInfoList) {
List<ShuffleServerInfo> allServers = sbi.getShuffleServerInfos();
+ if (replica > 1 && !shuffleServerBlacklist.isEmpty()) {
+ // allServers is shared and is not thread safe
+ synchronized (this) {
Review Comment:
I think lock is necessary here, or we need to create a new server list. And
this part will only be executed when `shuffleServerBlacklist` is empty, so i
think there is little impact here. How about `synchronized (allServers) `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
