advancedxy commented on PR #478: URL: https://github.com/apache/incubator-uniffle/pull/478#issuecomment-1380331912
Did a quick overview of the related code, I believe the better fix should be refactor `org.apache.uniffle.storage.handler.impl.LocalFileHandlerTestBase#calcSegmentBytes` by passing the correct `wroteBlockList` or just retrieve blocks from `blockIdToData` In a real environment, the blockId could be random and generated concurrently. `org.apache.uniffle.storage.handler.impl.LocalFileHandlerTestBase#ATOMIC_LONG` seems to be a good way to simulate it. also cc @zuston -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
